Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Module] Freesurfer registration #54

Open
wants to merge 31 commits into
base: main
Choose a base branch
from
Open

Conversation

anroy1
Copy link
Contributor

@anroy1 anroy1 commented Jan 19, 2024

Describe your changes

Initial module PR for registration tool using Freesurfer synthmorph converting transform to ants orientation.

Say which test data are used by your module

Checklist before requesting a review

  • Create the tool:
    • Edit ./modules/nf-scil/<category>/<tool>/main.nf
    • Edit ./modules/nf-scil/<category>/<tool>/meta.yml
  • Generate the tests:
    • Edit ./tests/modules/nf-scil/<category>/<tool>/main.nf
    • Edit ./tests/modules/nf-scil/<category>/<tool>/nextflow.config
    • Add test data locally for tests with the fork repository
    • Generate the test infrastructure and md5sum for all outputs
  • Ensure the syntax is correct :
    • Check indentation abides with the rest of the library (don't hesitate to correct others !)
    • Lint everything. Ensure your variables have good names.

@AlexVCaron
Copy link
Collaborator

@nf-scil-bot fix linting

1 similar comment
@AlexVCaron
Copy link
Collaborator

@nf-scil-bot fix linting

@AlexVCaron AlexVCaron changed the title Registration Freesurfer registration Mar 7, 2024
@AlexVCaron AlexVCaron changed the title Freesurfer registration Add Freesurfer registration module Mar 7, 2024
@AlexVCaron AlexVCaron changed the title Add Freesurfer registration module [Module] Freesurfer registration Mar 7, 2024
@anroy1 anroy1 force-pushed the registration branch 2 times, most recently from 8148b67 to 00fc10f Compare April 9, 2024 19:22
@anroy1 anroy1 force-pushed the registration branch 2 times, most recently from 6c16d91 to ec7d848 Compare April 26, 2024 01:33
Copy link
Collaborator

@AlexVCaron AlexVCaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, almost there ! 💪🏻 To be consistent with the remainder of the library, I would rather this module outputs standard file formats. You're there with Nifti, but lta should be converted to mat/txt, the easiest (mat prefered since binary).

@anroy1
Copy link
Contributor Author

anroy1 commented Jun 13, 2024

Regarding your comment on .lta format, it would be possible by adding the lta_convert function, as synthmorph affine output only .lta in RAS orientation. Making this module able to combine would require then to change the docker container: freesurfer/synthmorph --> freesurfer/freesurfer, which then require the licence management. This is mainly why I decided to split to create a separate module registration/convert. This is something we can discuss and think through.

@AlexVCaron
Copy link
Collaborator

Maybe one day we'll be able to fuse the containers, but for now, let's keep it like that. Add a short paragraph to the description in the meta referring to the conversion module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants