-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Module] Freesurfer registration #54
base: main
Are you sure you want to change the base?
Conversation
@nf-scil-bot fix linting |
1 similar comment
@nf-scil-bot fix linting |
8148b67
to
00fc10f
Compare
6c16d91
to
ec7d848
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, almost there ! 💪🏻 To be consistent with the remainder of the library, I would rather this module outputs standard file formats. You're there with Nifti, but lta should be converted to mat/txt, the easiest (mat prefered since binary).
Regarding your comment on .lta format, it would be possible by adding the lta_convert function, as synthmorph affine output only .lta in RAS orientation. Making this module able to combine would require then to change the docker container: freesurfer/synthmorph --> freesurfer/freesurfer, which then require the licence management. This is mainly why I decided to split to create a separate module registration/convert. This is something we can discuss and think through. |
Maybe one day we'll be able to fuse the containers, but for now, let's keep it like that. Add a short paragraph to the description in the meta referring to the conversion module. |
bee294e
to
c1e190f
Compare
Describe your changes
Initial module PR for registration tool using Freesurfer synthmorph converting transform to ants orientation.
Say which test data are used by your module
Checklist before requesting a review
./modules/nf-scil/<category>/<tool>/main.nf
./modules/nf-scil/<category>/<tool>/meta.yml
./tests/modules/nf-scil/<category>/<tool>/main.nf
./tests/modules/nf-scil/<category>/<tool>/nextflow.config