Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let scmp infer local address #3390

Closed
wants to merge 1 commit into from
Closed

Conversation

worxli
Copy link
Contributor

@worxli worxli commented Nov 15, 2019

This change is Reviewable

@matzf
Copy link
Contributor

matzf commented Nov 18, 2019

Related: #3376

Copy link
Contributor

@matzf matzf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @worxli)


go/tools/scmp/cmn/common.go, line 132 at r1 (raw file):

func ValidateFlags() {
	if Local.Host == nil {
		Local.Host = &addr.AppAddr{L3: addr.HostFromIPStr("127.0.0.1")}

With using localhost IP, we'd just not to receive a reply, unless we happen to run scmp echo on the border router. I think this should use the actual local source address used for sending the SCION packet; using netlink, we can look this up from the kernels routing tables. See also #3376, maybe we can join forces here.

@oncilla
Copy link
Contributor

oncilla commented Apr 11, 2020

Fixed by #3691

@oncilla oncilla closed this Apr 11, 2020
@worxli worxli deleted the scmp-echo branch June 7, 2021 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants