control: pluggable segment signer #4460
Conversation
Make the segment signer pluggable. This decouples the beacon extender from the trust signer implementation and allows plugging in different implementations.
oncilla
requested review from
lukedirtwalker,
jiceatscion,
marcfrei and
matzf
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @jiceatscion, @lukedirtwalker, and @marcfrei)
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2.
Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on @jiceatscion, @lukedirtwalker, and @marcfrei)
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:
There was a problem hiding this comment.
Third time's a charm 🤞
Reviewable status: 5 of 6 files reviewed, all discussions resolved (waiting on @jiceatscion, @lukedirtwalker, and @marcfrei)
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1, 1 of 1 files at r3, all commit messages.
Reviewable status:
Make the segment signer pluggable. This decouples the beacon extender from the trust signer implementation and allows plugging in different implementations.
Make the segment signer pluggable. This decouples the beacon extender from the trust signer implementation and allows plugging in different implementations.
This change is