-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Communication broker - part 1 / Multi-application handling interface part-2 #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion protocol changes
I will merge this one since it was reviewed in other PR and will be reviewed again in the PR #53 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed some problems from #45 thanks to the communication protocol updates.
Related to #41, #43
Main changes
broker
,beamlime.communications.broker.CommunicationBroker
.broker
follows theBeamlimeBrokerProtocol
which inheritsCommunicationProtocol
.broker
willget
,put
,consume
andproduce
data according to the type of channel that application is subscribing to.data-stream
configuration now has all application specs includingdata-reduction
.__init__
function ofBeamlimeApplicationInterface
updated so that it does not need to haveconfig
as a dictionary and parse it. All specs can be dumped by **config when it's instantiated.src/beamlime//offine/offline_system_example.ipynb
. It will be moved to docs later...!TODO - Things I will continue after the vacation!
put
andpoll
method implementation.