Amor reflectometry #32
Conversation
|
Closed and reopened to trigger CI. |
|
🎉 |
|
Unless there is a very specific reason, we let Sphinx auto-generate the notebook outputs (using |
|
Good point. I am used to putting notebooks that run for > 5 minutes into docs so time out nbsphinx! |
| "bins = (np.linspace(2.5, 15, 50), np.linspace(0.6, 1.25, 50))\n", | ||
| "lambda_theta = norm.wavelength_theta_bin(bins)" |
There was a problem hiding this comment.
This interface should be changed (in the future). As it is it negates all the benefits we have from scipp, making things obvious and safeguarded from errors:
- Which of the two refers to what?
- What are the units?
Similar for a number of other functions I think, but we can do that as a next step (but we actually have to do it, and avoid getting carried away by a flood of feature requests and pressure to continue implementing new things before consolidating what we have).
There was a problem hiding this comment.
Agreed, ideally this would be replaced with two sc.linspace calls 😉 (scipp/ess#15 (comment))
Companion to scipp/ess#15, showing the reduction process for the Amor instrument in action