Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow both bin edges and number of bins in parameter WavelengthBins #67

Merged
merged 2 commits into from
Jun 24, 2024

Conversation

jokasimr
Copy link
Contributor

Was originally part of #66 but this change needs to wait for a sciline release.

@YooSunYoung
Copy link
Member

sciline==24.2.1

It looks like the sciline version is not updated...!
@jokasimr can you please update the requirements? I don't have access to a linux machine atm...

@jokasimr
Copy link
Contributor Author

sciline==24.2.1

It looks like the sciline version is not updated...!
@jokasimr can you please update the requirements? I don't have access to a linux machine atm...

No worries, I'll update the requirements before merging. But I'll wait for the sciline release. Or do you have another idea?

@YooSunYoung
Copy link
Member

sciline==24.2.1

It looks like the sciline version is not updated...!
@jokasimr can you please update the requirements? I don't have access to a linux machine atm...

No worries, I'll update the requirements before merging. But I'll wait for the sciline release. Or do you have another idea?

Ah ha...! I thought 24.4 was including the necessary change but apparently not... then it's fine, thanks!

@jokasimr
Copy link
Contributor Author

Waiting for #73

@jokasimr jokasimr merged commit 0db19b2 into main Jun 24, 2024
3 checks passed
@jokasimr jokasimr deleted the wavelength-binning-union branch June 24, 2024 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants