Loki Direct Beam Iterations (version 2) #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ical and nonlogical dims
src/esssans/direct_beam.py
Outdated
| """ | ||
| from .loki.data import get_path | ||
|
|
||
| data = np.loadtxt(get_path(filename)) |
There was a problem hiding this comment.
This function will not be usable for anything but test data then? Can we avoid doing path handling here?
SimonHeybrock
approved these changes
Jan 16, 2024
…ined provider in beam_center_finder
SimonHeybrock
approved these changes
Jan 16, 2024
|
This is currently blocked by scipp/scippnexus#188 |
Can you use the single-threaded dask scheduler for now? |
SimonHeybrock
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the necessary functionality to the I(Q) providers to compute the direct beam function for the LoKI detector tubes, using detector test data obtained at Larmor.
Changes to the pipeline:
DirectRunhas been renamed toEmptyBeamRunDimsToKeepparameter can be used to computeComputing the direct beam function is illustrated in a notebook.