-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add superplot that can save lines on 1d slicer plot #34
Conversation
src/plopp/core/utils.py
Outdated
def coord_to_string(coord): | ||
out = value_to_string(coord.values) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this do to long coords?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's only designed to take in either one or two values, in the case of bin edges (i.e. a slice of a coord with a single index).
But you are right that I should make that more clear, either in the function name or in a docstring
Example:
Fixes #15