Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add superplot that can save lines on 1d slicer plot #34

Merged
merged 11 commits into from
Oct 4, 2022
Merged

Conversation

nvaytet
Copy link
Member

@nvaytet nvaytet commented Sep 29, 2022

Example:

%matplotlib widget
import plopp as pp
da = pp.data.dense_data_array(ndim=2)

pp.superplot(da, keep='xx', ls='solid', marker='None')

Screenshot at 2022-09-29 22-12-55

Fixes #15

@nvaytet nvaytet marked this pull request as draft September 29, 2022 20:15
@nvaytet nvaytet marked this pull request as ready for review September 30, 2022 13:41
Comment on lines 96 to 97
def coord_to_string(coord):
out = value_to_string(coord.values)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this do to long coords?

Copy link
Member Author

@nvaytet nvaytet Oct 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's only designed to take in either one or two values, in the case of bin edges (i.e. a slice of a coord with a single index).
But you are right that I should make that more clear, either in the function name or in a docstring

@nvaytet nvaytet merged commit b005b52 into main Oct 4, 2022
@nvaytet nvaytet deleted the superplot branch October 4, 2022 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add superplot for displaying 1d slices of 2d data, with ability to persist lines
2 participants