BUILD: kaleido should be python-kaleido for conda build #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should probably change this upstream in the copier template.
nvaytet
approved these changes
Sep 11, 2024
| @@ -35,7 +35,7 @@ test: | |||
|
|
|||
| {# Conda does not allow spaces between package name and version, so remove them #} | |||
| {% for package in test_dependencies %} | |||
| - {% if package == "graphviz" %}python-graphviz{% else %}{{ package|replace(" ", "") }}{% endif %} | |||
| - {% if package == "graphviz" %}python-graphviz{% elif package == "kaleido" %}python-kaleido{% else %}{{ package|replace(" ", "") }}{% endif %} | |||
There was a problem hiding this comment.
If we get more examples of this, we could do something like prepend python- to the package name if name in ["graphviz", "kaleido", ...], but this is fine for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should probably change this upstream in the copier template, but I guess we can unblock the release build of plopp for now.