Patch scipp classes on import #6
Conversation
src/plopp/__init__.py
Outdated
| from scipp import Variable, DataArray, Dataset | ||
|
|
||
| setattr(Variable, 'plot', plot) | ||
| setattr(DataArray, 'plot', plot) |
There was a problem hiding this comment.
So sc.plot would still call the old plotting, but the method the new one?
Should we consider (for now) patching only when explicitly calling a function?
There was a problem hiding this comment.
So sc.plot would still call the old plotting, but the method the new one?
Yes
Should we consider (for now) patching only when explicitly calling a function?
You mean, something like
def make_plopp_default():
from scipp import Variable, DataArray, Dataset
setattr(Variable, 'plot', plot)
setattr(DataArray, 'plot', plot)
setattr(Dataset, 'plot', plot)and then calling
import plopp
plopp.make_plopp_default()to do the patching?
There was a problem hiding this comment.
Yes, this is what I mean. And we should also patch scipp.plot in that case?
There was a problem hiding this comment.
Or do you plan to remove scipp.plot?
There was a problem hiding this comment.
We also need to patch scipp.plot for dicts of DataArrays. Any good ideas for a function name? make_plopp_default isn't great.
plopp.activate()?
src/plopp/__init__.py
Outdated
| setattr(Dataset, 'plot', plot) | ||
| def patch_scipp(): | ||
| """ | ||
| Running this replaces the legacy `plot` function from Scipp with the plopp `plot` |
There was a problem hiding this comment.
| Running this replaces the legacy `plot` function from Scipp with the plopp `plot` | |
| Running this replaces the `plot` function from Scipp with the plopp `plot` |
src/plopp/__init__.py
Outdated
| def patch_scipp(): | ||
| """ | ||
| Running this replaces the legacy `plot` function from Scipp with the plopp `plot` | ||
| wrapper. This patches both the Variable, DataArray, Dataset class methods, as well |
There was a problem hiding this comment.
It is not a classmethod, is it?
| import scipp as sc | ||
| setattr(sc.Variable, 'plot', plot) |
There was a problem hiding this comment.
How does this interact with import order, or importing scipp again after calling this?
There was a problem hiding this comment.
As far as I can tell, import order doesn' seem to matter.
import scipp as sc
import plopp as pp
pp.patch_scipp()
import scipp
scipp.plot(da)still gives the plopp plotting.
This enables to use
da.plot()after having importedplopp.