Remove hard dependency on ipywidgets and make SVG figures #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimonHeybrock
approved these changes
Sep 9, 2022
src/plopp/io.py
Outdated
| from io import BytesIO | ||
|
|
||
|
|
||
| def fig_to_pngbytes(fig, form='png'): |
There was a problem hiding this comment.
Suggested change
| def fig_to_pngbytes(fig, form='png'): | |
| def fig_to_bytes(fig, form='png'): |
?
src/plopp/io.py
Outdated
|
|
||
| def fig_to_pngbytes(fig, form='png'): | ||
| """ | ||
| Convert a Matplotlib figure to png bytes. |
src/plopp/static.py
Outdated
| """ | ||
| return { | ||
| 'text/plain': 'Figure', | ||
| 'image/svg+xml': fig_to_pngbytes(self._fig, form='svg').decode() |
There was a problem hiding this comment.
Is the size of 2d figures manageable? I expect an svg is much larger than png in that case?
There was a problem hiding this comment.
yes it is, but now we rasterize the pcolormesh
There was a problem hiding this comment.
Meaning... the mesh is not vector, but all the rest is?
There was a problem hiding this comment.
Yes, that's how I understand it, but maybe you can check on your display? since the difference between svg and png is not that huge on my monitor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_repr_mimebundle_homeorlogxon the toolbar or the figure and they will update each other