Add TaskGraph.keys #126
Merged
Add TaskGraph.keys #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/sciline/task_graph.py
Outdated
Comment on lines
116
to
120
| def keys(self) -> Generator[Key, None, None]: | ||
| """Iterate over all keys of the graph. | ||
|
|
||
| Yields all keys, i.e., the types of values that can be computed or are | ||
| provided as parameters. |
There was a problem hiding this comment.
Erm, this is odd, because we have self._keys, and the keys passed in the __init__, with a quite different meaning from what you implemented here.
There was a problem hiding this comment.
Renamed the args in other methods to targets to match the name in transform_coords.
src/sciline/task_graph.py
Outdated
| @@ -103,15 +103,28 @@ def compute( | |||
| If ``keys`` is a single type, returns the single result that was computed. | |||
| If ``keys`` is a tuple of types, returns a dictionary with type as keys | |||
There was a problem hiding this comment.
Docstring would need an update given the rename.
jl-wynen
force-pushed
the
iterate-graph
branch
from
bb2acd7
to
f7c67a3
Compare
SimonHeybrock
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed by scipp/essreflectometry#6
I went with
TaskGraph.keysinstead ofTaskGraph.nodesin order to avoid the discussion of whether data and provider nodes are conceptually separate or the same node, see #124.