Fix recursion error when using multiple Pipeline.set_param_series #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimonHeybrock
added a commit
to scipp/esssans
that referenced
this pull request
Apr 2, 2024
Needs bugfix release of Sciline with scipp/sciline#150. [no ci]
nvaytet
reviewed
Apr 2, 2024
| @@ -719,3 +719,23 @@ def to_str(x: int) -> str: | |||
| pl = sl.Pipeline((to_str,)) | |||
| pl.set_param_series(int, ints) | |||
| assert pl.compute(sl.Series[int, str]) == sl.Series(int, {1: '1', 2: '2', 3: '3'}) | |||
|
|
|||
|
|
|||
| def test_multiple_param_series_can_be_broadcast() -> None: | |||
There was a problem hiding this comment.
Did you also try putting the beam center finder provider back into the loki direct beam workflow with multiple files to see if it fixes it?
There was a problem hiding this comment.
I can also try it if you prefer.
There was a problem hiding this comment.
I did not try, no. Go ahead, since you know which pieces to touch!
nvaytet
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this does not happen with
Pipeline.set_param_table.