Fix blue cluster boxes in task graph visualization #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en using generics
| @@ -87,7 +87,7 @@ def get_subgraph_name(name: str, kind: str) -> str: | |||
| if kind == 'series': | |||
| # Example: Series[RowId, Material[Country]] -> RowId, Material[Country] | |||
| return name.partition('[')[-1].rpartition(']')[0] | |||
| return name | |||
| return name.split('[')[0] | |||
There was a problem hiding this comment.
Where/how was this actually broken?
There was a problem hiding this comment.
What about this discussion, where you pointed out something related? https://github.com/scipp/sciline/pull/124/files#r1489495340
There was a problem hiding this comment.
It never made clusters, it always returned RawData[Sample] and RawData[Background] instead of RawData for both which would then make a cluster, I think?
SimonHeybrock
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure we still have clusters in the visualization when using generics.
Fixes #151