Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement ADR 0001: Remove isinstance checks when setting params #160

Merged
merged 1 commit into from
Apr 17, 2024
Merged

Implement ADR 0001: Remove isinstance checks when setting params #160

merged 1 commit into from
Apr 17, 2024

Conversation

SimonHeybrock
Copy link
Member

No description provided.

@SimonHeybrock
Copy link
Member Author

Merging into feature branch, since I want to switch to 3.10 union syntax there to fix mypy, and it would require changing the isinstance checks being removed here.

@SimonHeybrock SimonHeybrock merged commit 81eadb3 into remove-optional-union Apr 17, 2024
5 checks passed
@SimonHeybrock SimonHeybrock deleted the remove-instance-checks branch April 17, 2024 03:50
@SimonHeybrock SimonHeybrock mentioned this pull request Apr 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jl-wynen jl-wynen jl-wynen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SimonHeybrock @jl-wynen