Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

papers/simon_lund: Revised based on reviewer feedback. #28

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

safl
Copy link

@safl safl commented Jul 29, 2014

Thank you for taking your time to review the paper.

I have revised the paper based on the marked-up pdf.

It is worth mentioning:

Some aspects of the cphVB project is no longer valid, the most essential
is the existence of the project since cphVB is deprecated, the efforts are
continued in the Bohrium project.

Some aspects of the cphVB project is no longer valid, the most essential
is the existence of the project since cphVB is deprecated, the efforts are
continued in the Bohrium project.
@ahmadia
Copy link
Member

ahmadia commented Jul 30, 2014

Thanks!

On Tue, Jul 29, 2014 at 7:53 PM, Simon A. F. Lund notifications@github.com
wrote:

Thank you for taking your time to review the paper.

I have revised the paper based on the marked-up pdf.

It is worth mentioning:

Some aspects of the cphVB project is no longer valid, the most essential
is the existence of the project since cphVB is deprecated, the efforts are

continued in the Bohrium project.

You can merge this Pull Request by running

git pull https://github.com/safl/scipy_proceedings_2012 master

Or view, comment on, or merge it at:

#28
Commit Summary

  • papers/simon_lund: Revised based on reviewer feedback.

File Changes

Patch Links:

https://github.com/scipy-conference/scipy_proceedings_2012/pull/28.patch

https://github.com/scipy-conference/scipy_proceedings_2012/pull/28.diff


Reply to this email directly or view it on GitHub
#28.

@mandli
Copy link

mandli commented Jul 30, 2014

@safl, I will make sure to take a look at your changes and make sure to take into account the difficultly involved with a project that has been deprecated in the intervening years. I will try to have some comments soon so stayed tuned.

@mandli
Copy link

mandli commented Aug 3, 2014

I finally got around to re-reading the paper today (sorry that took so long). Many of the structural issues have been resolved to my satisfaction. I think the primary issue is still the lack of details in the performance comparison but this is understandable given that the project has been deprecated. I think it might still be nice if you explain what the vector-engines "simple", "score" and "mcore" are in more detail.

@safl
Copy link
Author

safl commented Aug 3, 2014

I have added a brief description of the vector engines. Does it suffice? I find that it will be out of scope to describe the implementation in greater detail.

@mandli
Copy link

mandli commented Aug 3, 2014

Thanks, that helps a lot (I would not have guessed that was what you were doing). +1

@safl
Copy link
Author

safl commented Aug 4, 2014

Excellent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants