This repository has been archived by the owner on Dec 31, 2021. It is now read-only.
Improving submission module #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 6, 2014
1. Remove `submission.models.ZipFile`
ZIP files are no more staged
2. Rewrite `submission.forms.py` using model forms
a. `submission.models` now contains help text, labels for form fields
NOTE: Making keywords bold to show in HTML is now not done.
3. Rewrite views corresponding to create, edit submissions using class based views
Removed functions, views from views.py:
a. `get_form()`, `create_or_edit_submission_revision()`
`get_license_text()`, `new_or_edit_submission()`,
`edit_submission()`
New view handlers:
a. `BaseSubmission()`, `NewSubmission()`, `EditSubmission()`
Some of the functions are still retained
NOTE: New view handlers no longer provide previewing functionality from server. Rather it is now handled with JavaScript
4. Create new module `views` with `create.py`, `show.py`
a. `create.py` contain views to create/edit submission
b. `show.py` contain views to display
5. Create new module `submission.storage` to handle storing of submissions in filesystem.
6. Add new methods to `filestorage.dvcs_wrapper.py`
a. `remove()`, `purge()`, `update()`
NOTE: Needs to turn on `purge` extension in Mercurial (Hg) repository settings in `.hgrc` file on server
Minor Changes:
1. URL Conf for new submission is changed
from: `r'^new/(?P<item_type>[a-zA-Z]+)/$`
to : `r'^(?P<item_type>[a-zA-Z]+)/new/$'`
2. submit button in `submission/new-item.html` is enhanced to disable on submitting the form to server using JavaScript
3. `person.views.profile_page_edit` view's `item` context is renamed to `form` to support default class based views context in `submission/new-item.html`
This was referenced May 13, 2014
|
@ksurya nice going! |
|
@rgommers Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
submission.models.ZipFileRewrite
submission.forms.pyusing model formsa.
submission.modelsnow contains help text, labels for form fieldsNOTE: Making keywords bold to show in HTML is now not done.
Rewrite views corresponding to create, edit submissions using class based views
Removed functions from views.py:
a.
get_form(),create_or_edit_submission_revision(),get_license_text(),new_or_edit_submission(),edit_submission()New view handlers:
a.
BaseSubmission(),NewSubmission(),EditSubmission()NOTE: New view handlers no longer provide previewing functionality from server. Rather it is now handled with JavaScript
Create new module
viewswithcreate.py,show.pya.
create.pycontain views to create/edit submissionb.
show.pycontain views to displayCreate new module
submission.storageto handle storing of submissions in filesystem.Add new methods to
filestorage.dvcs_wrapper.pya.
remove(),purge(),update()NOTE: Needs to turn on
purgeextension in Mercurial (Hg) repository settings in.hgrcfile on serverMinor Changes:
from:
r'^new/(?P<item_type>[a-zA-Z]+)/$to :
r'^(?P<item_type>[a-zA-Z]+)/new/$'person.views.profile_page_editview'sitemcontext is renamed toformto support default class based views context insubmission/new-item.html