Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtests.py is missing in pypi distfile #6498

Closed
0-wiz-0 opened this issue Aug 19, 2016 · 4 comments
Closed

runtests.py is missing in pypi distfile #6498

0-wiz-0 opened this issue Aug 19, 2016 · 4 comments
Labels
needs-decision Items that need further discussion before they are merged or closed
Milestone

Comments

@0-wiz-0
Copy link

0-wiz-0 commented Aug 19, 2016

HACKING.rst.txt says that one should run python runtests.py -v for testing, but the file is missing in the tarball uploaded to pypi. Please add it.

@0-wiz-0
Copy link
Author

0-wiz-0 commented Aug 19, 2016

When I manually download that file from github, running the tests also complains about a missing .coveragerc, please add that too.

@person142
Copy link
Member

Note that you can also do python -c "import scipy; scipy.test('full')".

@person142
Copy link
Member

To be fair, that section of HACKING.rst.txt is in the "Recommended Development Setup" section and has just told the user they must clone the Git repo. ISTM that runtests.py is a development tool and not something that should be uploaded to pypi.

@rgommers rgommers added the needs-decision Items that need further discussion before they are merged or closed label Oct 2, 2016
@rgommers
Copy link
Member

rgommers commented Oct 2, 2016

@person142 that sounds right to me. On the other hand we do upload tox.ini and tools/, which isn't really needed either. So it's a bit inconsistent.

We should probably just add runtests.py for consistency and archiving. There may be other files missing. A test script that checks all files in paver sdist vs all files under version control would be useful.

rgommers added a commit to rgommers/scipy that referenced this issue Sep 2, 2018
@pv pv closed this as completed in #9206 Sep 2, 2018
@rgommers rgommers added this to the 1.2.0 milestone Sep 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-decision Items that need further discussion before they are merged or closed
Projects
None yet
Development

No branches or pull requests

3 participants