MAINT: rename moduleTNC extension back to _moduleTNC
#15270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgommers
added
scipy.optimize
maintenance
|
Ah, ugh: Guess that was your reason to drop the underscore - when moving to Cython, the name is picked automatically based on the filename - so that filename should gain the underscore as well. |
The underscore was recently removed, see scipygh-14882. This change is undesired, because it's a private namespace.
rgommers
force-pushed
the
moduletnc-underscore
branch
from
792a41f
to
d9e974e
Compare
rgommers
commented
Dec 23, 2021
| @@ -32,7 +32,7 @@ | |||
| (as a list of values); or None, to abort the minimization. | |||
| """ | |||
|
|
|||
| from scipy.optimize import moduleTNC | |||
| from scipy.optimize import _moduleTNC as moduleTNC | |||
There was a problem hiding this comment.
This is a straight revert; I considered dropping the as moduleTNC, but that would break the backwards compat import in optimize/tnc.py.
tylerjereddy
approved these changes
Dec 23, 2021
tylerjereddy
removed
the
backport-candidate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The underscore was recently removed, see gh-14882.
This change is undesired, because it's a private namespace.