-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make signal functions respect input dtype. #15366
Conversation
The CI is now throwing three test errors after the last commit. I can't reproduce them in my local machine. I'm not familiar with |
I tried to reproduce the errors reported by the CI with a 32-bits Debian VM but no luck. This error appears to be similar to this Satpy error. Any theories appreciated! |
A restart fixed the errors, this LGTM, @tylerjereddy's comment has been addressed, and @ilayn approved already, so in it goes. Thanks @luigifcruz ! |
This pull request ensures that the data type from the input and output are the same. This results in an expressive 35% speedup in single-precision Hilbert operations.