-
Notifications
You must be signed in to change notification settings - Fork 132
Speedup: Single-precision hilbert, resample, and lfilter_zi. #447
Conversation
[RELEASE] cusignal v0.13
[RELEASE] cusignal v0.14
[HOTFIX] Fix missing six package on cusignal import [skip-ci-changelog]
[skip ci] Update master references for main branch
[RELEASE] cusignal v0.16
[RELEASE] cusignal v0.17
[RELEASE] cusignal v0.18
[RELEASE] cusignal v0.19
REL Fix `21.06` Release Changelog
[RELEASE] cusignal v21.08
[RELEASE] cusignal v21.10
[RELEASE] cusignal v21.12
Hi @luigifcruz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please type specific tests as well, in test_filtering.py
@pytest.mark.benchmark(group="Hilbert")
@pytest.mark.parametrize("dtype", [np.float32, np.float64])
@pytest.mark.parametrize("dim, num_samps", [(1, 2 ** 15), (2, 2 ** 8)])
class TestHilbert:
...
Thanks for the PR @luigifcruz! Once you make these suggested changes from @mnicely, we'll merge. I changed the merge target branch to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving ops-codeowner
file changes
Thanks for the feedback @mnicely & @awthomp! I implemented the requested style changes with 9d6d7aa and type check tests with bc9dcd9. I had to patch the I also noticed that the |
@mnicely -- I don't think we can merge until you sign off on @luigifcruz 's fixes. Can you give this a look? Looks great, Luigi. You're the best! Thanks, as always, for contributing. |
@gpucibot merge |
Awesome, @awthomp! Thanks all for maintaining this awesome project! |
Hi!
I noticed some functions weren't respecting the input type and thus returning double precision results.
This pull request proposes two changes:
resample
return a buffer with the samedtype
as input.hilbert
andhilbert2
kernels.I also benchmarked each change: