Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEP: add actual DeprecationWarning for sym_pos-keyword of scipy.linalg.solve #15821

Merged
merged 9 commits into from
Mar 20, 2022

Conversation

j-bowhay
Copy link
Member

Reference issue

Closes #15735

What does this implement/fix?

The sym_pos keyword of scipy.linalg.solve has been deprecated in the documentation but no explicit warning is raised. This pr raises a deprecation warning so that sym_pos can be removed in SciPy 1.11.0.

Additional information

scipy/linalg/_basic.py Outdated Show resolved Hide resolved
[skip azp] [skip actions]
scipy/linalg/_basic.py Outdated Show resolved Hide resolved
scipy/linalg/_basic.py Outdated Show resolved Hide resolved
[skip actions] [skip azp]
@ilayn
Copy link
Member

ilayn commented Mar 20, 2022

Thanks @j-bowhay. There are a few instances of sym_pos in the SciPy codebase too; two that I could detect are

return sp.linalg.solve(M, r, sym_pos=sym_pos)

a = solve(Q, b, sym_pos=True, check_finite=False)

which needs to be converted to assume_a = 'pos'.

scipy/linalg/_basic.py Outdated Show resolved Hide resolved
@h-vetinari h-vetinari added scipy.linalg deprecated Items related to behavior that has been deprecated labels Mar 20, 2022
@h-vetinari h-vetinari added this to the 1.9.0 milestone Mar 20, 2022
@j-bowhay j-bowhay requested a review from andyfaff as a code owner March 20, 2022 08:20
scipy/linalg/tests/test_basic.py Outdated Show resolved Hide resolved
scipy/linalg/_basic.py Outdated Show resolved Hide resolved
scipy/linalg/tests/test_basic.py Outdated Show resolved Hide resolved
@ilayn
Copy link
Member

ilayn commented Mar 20, 2022

Looks good now. Thanks @j-bowhay , @h-vetinari, @mdhaber .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecated Items related to behavior that has been deprecated scipy.linalg
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DEP: add actual DeprecationWarning for sym_pos-keyword of scipy.linalg.solve
5 participants