TST: cluster: some cleanups in test_hierarchy.py #3766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some new tests are skipped when matplotlib is unavailable so the coverage is different on Travis. |
|
LGTM, but all the data text files are getting out of hand. Unless you intend to test file reading it would clean things up if you could put all that data into one place. I'll merge this as is and that cleanup, if made, can be another PR. |
charris
added a commit
that referenced
this pull request
Jun 30, 2014
TST: cluster: some cleanups in test_hierarchy.py
|
Thanks @richardtsai. |
|
Re text files: not even in one place, but delete and replace with Python code. First file in this PR is simply |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use Nose's tests generator to merge some tests to reduce the file size and make it clearer.
Some tests are added. The test coverage of
cluster.hierarchyincreases from 59% to 72%.