TST: Break up upfirdn tests & compare to lfilter #5997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@@ master #5997 diff @@
======================================
Files 238 238
Stmts 43768 43768
Branches 8221 8221
Methods 0 0
======================================
Hit 34199 34199
Partial 2601 2601
Missed 6968 6968
|
|
Looks reasonable to me |
|
Ok. If no one objects, I'll merge this soon. |
|
Thanks @e-q |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on gh-5975, @Eric89GXL had the idea to compare
upfirdn's output withlfilterfor purposes of decimation. This PR adds that test, and restructures theupfirdntest code to make it a little easier to add future tests.What do you think @Eric89GXL?