BUG: stats: Inconsistency in the multivariate_normal docstring #6263 #6285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgommers
added
scipy.stats
maintenance
| x = np.random.randn(5) | ||
| d1 = multivariate_normal.logpdf(x) | ||
| d2 = multivariate_normal.pdf(x) | ||
| assert_allclose(d1, np.log(d2)) |
There was a problem hiding this comment.
Here you test only that pdf and logpdf have consistent defaults. Probably you also want to test that the defaults are what they should be. So test (x) against (x, None, 1)
|
The extra test would be nice to have, other than that this looks good to merge. Thanks @BhavikaT |
|
I can add the extra test but I'm not sure what would be a good name for it. Since we're still testing for default values, I can't think of anything better than 'test_logpdf_default_values_2' but I'm not sure this is acceptable. Is it okay if I combine the two tests? |
|
Combining the two tests is perfectly fine. |
|
Done. Let me know if this is correct. Thank you @rgommers. |
|
Merged, thanks @BhavikaT. Keep them coming! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempting to close #6263.
I've added a test that covers
logpdftests using themeanandcovvalues specified in the docstring formultivariate_normal_gen.