BUG: Fix linear_sum_assignment hanging on an undefined matrix #7031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgommers
added
maintenance
|
LGTM, thanks @evanlimanto |
|
`cost_matrix.dtype is np.dtype(np.bool)` should use `==` instead of
`is`. Dtypes should not be assumed to be singletons (this is not true
for all types) --- if they sometimes are, this probably should be
considered is an implementation detail.
|
Thanks @pv, didn't know that. Will send a follow-up PR now. |
rgommers
added a commit
to rgommers/scipy
that referenced
this pull request
Feb 16, 2017
Follow-up to scipygh-7031. Thanks to @pv for pointing out that dtypes must not be considered singletons.
evanlimanto
pushed a commit
to evanlimanto/scipy
that referenced
this pull request
Mar 17, 2017
Follow-up to scipygh-7031. Thanks to @pv for pointing out that dtypes must not be considered singletons.
evanlimanto
pushed a commit
to evanlimanto/scipy
that referenced
this pull request
Mar 23, 2017
Follow-up to scipygh-7031. Thanks to @pv for pointing out that dtypes must not be considered singletons.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issues #6370, #7005 by checking if the matrix contains inf or nan. Also added additional checks for non-numeric data types. Related: #6900