MAINT: Switch np.where(c) for np.nonzero(c) #8972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rationale: * np.nonzero(c) is faster * np.nonzero(c) has better docs, whereas np.where(c) mixes the docs with the unrelated np.where(c, x, y) * There should be one-- and preferably only one --obvious way to do it. * Rearranges these into a form where `np.flatnonzero` can now obviously be substituted (in a future PR)
|
I think this failure's on me - I'll come back to it in a few days |
|
LGTM, thanks Eric. Test failures were unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale:
np.nonzero(c) is (negligibly) fasternp.flatnonzerocan now obviously be substituted (in a future PR)