Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Added "See Also" section to lombscargle docstring #9022

Merged
merged 1 commit into from
Jul 12, 2018

Conversation

migueldvb
Copy link
Contributor

  • DOC: Added "See Also" section

  • DOC: Fixed imports in docstring example

  • STY: PEP8 corrections

@rgommers rgommers added scipy.signal Documentation Issues related to the SciPy documentation. Also check https://github.com/scipy/scipy.org labels Jul 12, 2018
@rgommers
Copy link
Member

CI failures were The job exceeded the maximum time limit for jobs, and has been terminated. and a timeout on CircleCI - can be ignored.

Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @migueldvb, looks good except from my one minor comment.

Examples
--------
>>> import scipy.signal
>>> import numpy as np
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this import is not needed, it's implied in all examples in scipy. can you remove it?

* DOC: Added "See Also" section

* DOC: Fixed imports in docstring example

* STY: PEP8 corrections
@migueldvb
Copy link
Contributor Author

I have removed the import numpy line in the example.

@rgommers rgommers merged commit 9330404 into scipy:master Jul 12, 2018
@rgommers
Copy link
Member

Thanks @migueldvb, merged.

@rgommers rgommers added this to the 1.2.0 milestone Jul 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Issues related to the SciPy documentation. Also check https://github.com/scipy/scipy.org scipy.signal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants