Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix <li> indentation #79

Merged
merged 1 commit into from
Aug 9, 2021
Merged

fix <li> indentation #79

merged 1 commit into from
Aug 9, 2021

Conversation

terrychan999
Copy link
Contributor

No description provided.

@yungyuc
Copy link
Contributor

yungyuc commented Aug 8, 2021

Thanks @terrychan999 .

@chestercheng IIRC we used tailwind to generate the css? If we manually modify the style file, would it conflict with tailwind?

If it conflicts, what would we like to do? I can think of two possibilities: (i) give up tailwind and maintain style sheets manually and (ii) use tailwind to make the style change.

ref #76

@yungyuc yungyuc added the bug Something isn't working label Aug 8, 2021
@terrychan999
Copy link
Contributor Author

main.css is actually generated by tailwind.

Because from the Makefile I notice make deploy doesn't trigger make css to invoke tailwind,
so I use make css to generate it.

@yungyuc
Copy link
Contributor

yungyuc commented Aug 8, 2021

I missed main.css in the first place. Is it necessary to do the generation in this PR? If not, is it possible to only update styles.css? Diff on main.css is so large. It is 6xk lines of code.

@chestercheng
Copy link
Contributor

It's my fault, the main.css should not pushed into this repo...

@yungyuc
Copy link
Contributor

yungyuc commented Aug 9, 2021

It's my fault, the main.css should not pushed into this repo...

If it is not in the repository, would tailwind be a dependency when we build the repo locally?

I do not have tailwind installed. If tailwind becomes a dependency, I need to learn how to install it and I think it should be documented somewhere in the repo.

Let us give it more discussions before jumping to a conclusion.

@terrychan999
Copy link
Contributor Author

If it is not in the repository, would tailwind be a dependency...

Yes, npx (npm package executor)(bundled with Node.js) will then become a dependency to build tailwind locally.

@yungyuc
Copy link
Contributor

yungyuc commented Aug 9, 2021

If it is not in the repository, would tailwind be a dependency...

Yes, npx (npm package executor)(bundled with Node.js) will then become a dependency to build tailwind locally.

Ok. It seems to be clear that, in the time being, to update style sheets we need to update main.css. Let's make the dependency on tailwind a separate issue.

I am merging this PR. Thanks a lot @terrychan999 !

@yungyuc yungyuc merged commit cf67150 into sciwork:develop Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working stylesheet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants