Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing python 3 support #4

Merged
merged 5 commits into from
Feb 17, 2020
Merged

fixing python 3 support #4

merged 5 commits into from
Feb 17, 2020

Conversation

thomasgilgenast
Copy link
Member

this PR fixes python 3 support and adds testing and linting powered by tox and github actions

uses tox to test py27 and py36 and lint

this commit tests whether or not running tox in github actions will
actually trigger the lint test

this commit contains an intentional style error which should fail the
github action if it actually runs the linter
@thomasgilgenast thomasgilgenast merged commit 955e685 into master Feb 17, 2020
@thomasgilgenast thomasgilgenast deleted the feature/py3-support branch February 17, 2020 06:16
@tritzsm
Copy link
Member

tritzsm commented Feb 17, 2020

Merging PRs without getting a +1 tsk tsk

@thomasgilgenast
Copy link
Member Author

Just wait until you see the eight commits I made directly to master after merging this PR 😉 .

(Disclaimer: I definitely welcome and appreciate code review and comments even after the fact. This is basically "alpha" software, so we can roll back, amend, or improve the changes I've made at any time without any real consequences.)

@sclabs sclabs locked as too heated and limited conversation to collaborators Feb 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants