Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup ESLint #4

Merged
merged 9 commits into from
Jan 24, 2024
Merged

Setup ESLint #4

merged 9 commits into from
Jan 24, 2024

Conversation

sclaret
Copy link
Owner

@sclaret sclaret commented Jan 24, 2024

This branch adds ESLint to the project, configured to work with Preact.

It can be run via Make, and CI.

npm init @eslint/config
problems
esm
none
no
browser
javascript
yes
yarn
yarn add -D eslint-config-preact
Error: Error while loading rule 'jest/no-deprecated-functions': Unable to detect Jest version - please ensure jest package is installed, or otherwise set version explicitly

 preactjs/eslint-config-preact#19
Disable keys in the generated eslint config file that clash with eslint-config-preact.

Notes:

- Eslint-config-preact is holding back ecmascript version, and using a non-standard parser.  This could be fixed upstream or in a fork.

- Eslint-config-preact has no support for typescript.

- Eslint-config-preact targets eslint 8.x; it will need to be updated for eslint 9.x.
@sclaret sclaret merged commit 8357861 into main Jan 24, 2024
1 check passed
@sclaret sclaret deleted the setup_eslint branch January 24, 2024 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant