Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added extension point #26

Closed
wants to merge 2 commits into from
Closed

Added extension point #26

wants to merge 2 commits into from

Conversation

andreasschramm
Copy link

Hi, please consider adding extension points for users.

@centos-ci
Copy link
Collaborator

Can one of the admins verify this patch?

1 similar comment
@rhscl-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@hhorak hhorak self-assigned this Feb 23, 2017
@hhorak
Copy link
Member

hhorak commented Apr 26, 2017

Thanks for the contribution, we had several discussions about how to make this generally and it currently seems like using s2i approach might be better, see #34 for more details.

@andreasschramm
Copy link
Author

I was about to ask about that, i have seen your pull request, and agree it might be a better approach.
I have yet to find out the best way to do some other things, yum and whatever.

@hhorak
Copy link
Member

hhorak commented Apr 27, 2017

Sorry, my previous comment mentioned #34, but I wanted to point to #32.. but you probably found the right one.. I've also added an example of a Dockerfile that changes USER and thus can install additional packages -- https://github.com/hhorak/mariadb-container/blob/s2i-support/10.1/test/Dockerfile

@andreasschramm
Copy link
Author

thanks, i was unsure on to how to do it "the right way", dockerfile or assemble. Still finding out the best way to provide such functionality in a userfriendly way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants