-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add images for nodejs version 14 #246
Conversation
23d5766
to
81b0697
Compare
as Fedora 30 is already EOL and images got removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this new version and this PR!. Some small comments and improvements.
Seems like we have a limitation of only being able to have one image version per Fedora release, else the higher version overrides the lower one :/
|
New changes pushed. Will create a tracker for the issue mentioned above and downgrade node 10 to fc31 base image for now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one comment, regarding nodemon. It should be a part of Dockerfile.fedora.
What about imagestreams? Do you plan to updated as well? If not, then I think, tests are going to be failed on test_lastest_imagestreams?
If imagestreams 14 do not exist yet, then I think Makefile should have a VERSIONS like:
VERSIONS=10 14 12
What do you think?
Sorry for noise regarding imagestreams. If .exclude-{OS} are present, thank tests is skipped. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!. LGTM as soon as tests are passing!!!!
Fedora 31 does not have nodejs-nodemon so no changes for node 10
[test] |
No description provided.