Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python 3.11 and Fedora 37 + some small updates #561

Merged
merged 2 commits into from
Dec 9, 2022
Merged

Conversation

frenzymadness
Copy link
Member

No description provided.

@frenzymadness
Copy link
Member Author

[test-all]

@frenzymadness
Copy link
Member Author

[test-all]

@frenzymadness
Copy link
Member Author

@zmiklank Could you please take a look at the changes I've made in .github/? Are those enough to test and publish the new container image?

@zmiklank
Copy link
Contributor

zmiklank commented Dec 6, 2022

Yes, I think the changes are sufficient.

@frenzymadness
Copy link
Member Author

Yes, I think the changes are sufficient.

Thanks for the quick reply but I don't see the tests for Python 3.11 running here.

@zmiklank
Copy link
Contributor

zmiklank commented Dec 6, 2022

Stuff from .github/workflows/ are in the PR being taken from master branch, not from PR branch. You can first merge only these changes separately and then continue your work at this PR.

@zmiklank
Copy link
Contributor

zmiklank commented Dec 6, 2022

It should be also stated in the contribution.md, but it is not. I will add it there eventually.

@frenzymadness
Copy link
Member Author

Stuff from .github/workflows/ are in the PR being taken from master branch, not from PR branch. You can first merge only these changes separately and then continue your work at this PR.

If I do that. What will happen in the master branch where 3.11 does not exist? Will the actions just ignore non-existing images/folders/combinations?

@zmiklank
Copy link
Contributor

zmiklank commented Dec 6, 2022

The actions (either build-and-push and test action) will fail on Python 3.11 target. Other targets should not be affected by it.

@frenzymadness
Copy link
Member Author

[test]

1 similar comment
@frenzymadness
Copy link
Member Author

[test]

@frenzymadness frenzymadness marked this pull request as ready for review December 9, 2022 12:06
@frenzymadness frenzymadness merged commit ff7f5d6 into master Dec 9, 2022
@frenzymadness frenzymadness deleted the py311 branch December 9, 2022 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants