Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove github_summary_test workflow #191

Merged
merged 1 commit into from
Jun 3, 2024
Merged

Conversation

jamacku
Copy link
Member

@jamacku jamacku commented May 30, 2024

The job summary is generated by default for all tests, so this workflow is redundant. Also it is failing for long time due to wrong configuration.

Let's remove it.

Summary is generated by default for all tests, so this workflow is
redundant. Also it is failing for long time due to wrong configuration.

Let's remove it.
@jamacku jamacku requested a review from phracek May 30, 2024 12:20
Copy link

codecov bot commented May 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.33%. Comparing base (07b8a51) to head (e05cfb2).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #191   +/-   ##
=======================================
  Coverage   88.33%   88.33%           
=======================================
  Files          10       10           
  Lines         686      686           
  Branches       72       72           
=======================================
  Hits          606      606           
  Misses         78       78           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jamacku
Copy link
Member Author

jamacku commented May 31, 2024

[test]

Copy link
Member

@phracek phracek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phracek phracek merged commit 1a17482 into sclorg:main Jun 3, 2024
10 of 11 checks passed
@zmiklank
Copy link
Collaborator

zmiklank commented Jun 3, 2024

Please adjust the README accordingly too:
image
It seems v2 no longer supports the key=value option, and I am not sure there is some usecase for it anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants