This repository has been archived by the owner on Dec 11, 2018. It is now read-only.
Technical test for Schibsted #36
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New properties for tweet added, publicationDate, discarded, discardedDate TweetRepository created for the SQL methods TweetService refactored for extracting the SQL from it Ability to add links in the tweet without affecting the lenght of it /discarded endpoint added for discarding an existing tweet and for listing all discarded tweets New tests added No tests for TweetRepository
.getignore updated for excluding the out folder
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did not include the Repository tests because I think Unit Tests are not necessary there but we should use integration tests for this scenario.