Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/side effects #12

Merged
merged 6 commits into from
Oct 17, 2020
Merged

Bugfix/side effects #12

merged 6 commits into from
Oct 17, 2020

Conversation

atait
Copy link
Collaborator

@atait atait commented Oct 13, 2020

  1. Supported pytest framework, in case it is preferred over nose
  2. Transformer context is now derived from a shallow copy of __globals__
  • we don't want a function closure variable to be added to module globals

If a is defined in globals, it makes its way to context, and then

for a in range(3):
    x = a

is collapsed to

for 0 in range(3):
    x = 0

It might be possible to support this, but I'm not sure how, and it should probably not be allowed.

@coveralls
Copy link

coveralls commented Oct 13, 2020

Pull Request Test Coverage Report for Build 106

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 85.924%

Totals Coverage Status
Change from base Build 104: 0.1%
Covered Lines: 1056
Relevant Lines: 1229

💛 - Coveralls

This was referenced Oct 13, 2020
@atait atait merged commit a032639 into scnerd:develop Oct 17, 2020
@atait atait deleted the bugfix/side-effects branch October 17, 2020 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants