Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utilize iloc rather than integer keys #15

Closed
sco1 opened this issue Jan 1, 2024 · 0 comments · Fixed by #18
Closed

Utilize iloc rather than integer keys #15

sco1 opened this issue Jan 1, 2024 · 0 comments · Fixed by #18
Labels
internals Updates to things that aren't user-facing

Comments

@sco1
Copy link
Owner

sco1 commented Jan 1, 2024

Starting with Pandas v2.1.0 we start to get deprecation warnings on some of our data access, e.g.:

FutureWarning: Series.__getitem__ treating keys as positions is deprecated. In a future version, integer keys will always be treated as labels (consistent with DataFrame behavior). To access a value by position, use `ser.iloc[pos]`
    assert log_obj.press_temp["press_alt_m"][0] == pytest.approx(136.20, abs=1e-2)

This may only be in the test code but should check over the rest of the codebase

@sco1 sco1 added the internals Updates to things that aren't user-facing label Jan 1, 2024
sco1 added a commit that referenced this issue Jan 2, 2024
@sco1 sco1 mentioned this issue Jan 3, 2024
@sco1 sco1 closed this as completed in #18 Jan 3, 2024
sco1 added a commit that referenced this issue Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internals Updates to things that aren't user-facing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant