Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Annotation regex is broken. #3

Closed
scolej opened this issue Oct 7, 2017 · 2 comments
Closed

Annotation regex is broken. #3

scolej opened this issue Oct 7, 2017 · 2 comments

Comments

@scolej
Copy link
Owner

scolej commented Oct 7, 2017

Need to include trailing and leading whitspace. Should have used an actual Java file to test. Would have caught this one.
@scolej scolej closed this as completed in 72057fa Feb 17, 2018
scolej added a commit that referenced this issue Feb 17, 2018
@scolej
Fixing things!
5746281 
- Happy faces in test! (Should probably use a real test framework at
  some stage.)
- Fix GH-3 by improving tests and alter matching regexp.
- Use Java logging, and write to a file.
- Log build info at startup. (Should probably also log dirty/clean.)
- Gradle wrapper.
@maccoda
Copy link
Contributor

maccoda commented Feb 17, 2018

😮 This is closed before the build even completed!

scolej added a commit that referenced this issue Feb 17, 2018
@scolej
Fixing things!
a4e7834 
- Happy faces in test! (Should probably use a real test framework at
  some stage.)
- Fix GH-3 by improving tests and alter matching regexp.
- Use Java logging, and write to a file.
- Log build info at startup. (Should probably also log dirty/clean.)
- Gradle wrapper.
@scolej
Copy link
Owner Author

scolej commented Feb 17, 2018

Yeah maybe I was a bit eager with the "Fixes" ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@scolej @maccoda