-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(env): complete commands and variable assignments #1118
Conversation
Test coverage is likely something to expand before we merge this. Would be nice to also address |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can add tests.
Refs #1111 Co-authored-by: Koichi Murase <myoga.murase@gmail.com>
I added further commits because However, I noticed that if we pass the position of In addition, after the option |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Good to go as far as I'm concerned (GH won't let me approve this because I'm the original submitter).
Thanks! There are actually similar cases for |
Refs #1111