This repository has been archived by the owner on Jul 4, 2024. It is now read-only.
chore: add deprecation #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Johannes Würbach <johannes.wuerbach@googlemail.com>
|
@johanneswuerbach can we update the code to log a message indicating the deprecation? I worry folks won't really see this update in the docs if they are already using score-humanitec in workflows. |
sujaya-sys
approved these changes
May 8, 2024
TobiasBabin
reviewed
May 8, 2024
Co-authored-by: Tobias Babin <140624220+TobiasBabin@users.noreply.github.com> Signed-off-by: Johannes Würbach <johannes.wuerbach@googlemail.com>
Signed-off-by: Johannes Würbach <johannes.wuerbach@googlemail.com>
johanneswuerbach
force-pushed
the
deprecation
branch
from
980e071
to
b0ba47e
Compare
johanneswuerbach
commented
May 8, 2024
| @@ -42,3 +42,5 @@ brews: | |||
| commit_author: | |||
| name: rachfop | |||
| email: prachford@icloud.com | |||
| custom_block: | | |||
There was a problem hiding this comment.
custom_block as described in https://goreleaser.com/customization/homebrew/
johanneswuerbach
commented
May 8, 2024
| @@ -42,3 +42,5 @@ brews: | |||
| commit_author: | |||
| name: rachfop | |||
| email: prachford@icloud.com | |||
| custom_block: | | |||
| deprecate! date: "2024-05-08", because: "has been replaced by humctl score deploy. For more information visit https://developer.humanitec.com/platform-orchestrator/reference/cli-references/#score-integration." | |||
There was a problem hiding this comment.
deprecate! as described in https://docs.brew.sh/Deprecating-Disabling-and-Removing-Formulae
astromechza
approved these changes
May 9, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add deprecation notice. [Rendered].
Types of changes
Checklist: