Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command line usage is incorrect with v3.1.0 #84

Closed
wyze opened this issue Feb 12, 2019 · 7 comments
Closed

Command line usage is incorrect with v3.1.0 #84

wyze opened this issue Feb 12, 2019 · 7 comments

Comments

@wyze
Copy link

wyze commented Feb 12, 2019

I came across this because our docker images stopped serving files correctly. Our command is pushstate-server ./dist 8080 which worked fine in 3.0.1, but after getting 3.1.0 it uses the default port (9000) instead of 8080.

Just thought I'd log an issue here so readme could be updated or changes could be made to bring back that functionality.

@janhartmann
Copy link

janhartmann commented Feb 13, 2019

This just broke our deployments. Please update the docs.

@scottcorgan
Copy link
Owner

This is accidentally a breaking change. Sorry about that. Which port would you prefer?

@janhartmann
Copy link

janhartmann commented Feb 13, 2019

I would prefer specifying it, just like the previous version:

pushstate-server ./ 5000

But this will mount on 9000 in v3.1.0

@weichengcheng
Copy link

weichengcheng commented Feb 23, 2019

The original command is unavailable. Please update the docs.

@blocka
Copy link

blocka commented Jul 19, 2019

I'm gonna guess this is a regression in minimist? It seems the only thing that changed is that you now have to specify the options directly

pushstate-server -d ./dist -p 8080

@blocka
Copy link

blocka commented Jul 19, 2019

or maybe it's all been broken since this commit: 0e07d43#diff-a9b3224c7bedc40cad54b9dfab96553e

@wyze
Copy link
Author

wyze commented Apr 18, 2020

Looks like readme has been updated with #85.

@wyze wyze closed this as completed Apr 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants