Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respond stops on } in comments #150

Closed
PaulShipley opened this issue Aug 29, 2012 · 3 comments
Closed

Respond stops on } in comments #150

PaulShipley opened this issue Aug 29, 2012 · 3 comments

Comments

@PaulShipley
Copy link

This is more a "Gottya" than a bug and I have not checked the code yet, but maybe this will save someone else some head scratching.

Issue was that Respond would stop parsing a style sheet before the end. After a bit of trial and error, problem was due to a comment in the form

/* blah blah blah } blah */

Removing the '}' fixed the problem.

Solution: Don't put '}' characters in comments.

@primavera133
Copy link

Second this one. Had comments like this break for me:

/*
.class-name {
background: #f30;
}
*/

When I removed the curly brackets it worked again.

@localpcguy
Copy link

Just ran into this problem as well. Anytime we commented out CSS styles it would break. Thinking stripping comments out before parsing the rest of the CSS might be a relatively easy way to fix this? Looks like #98 may be helpful, I'll submit a similar pull request that has a slightly different regex, but pretty similar to #98

@jefflembeck
Copy link
Collaborator

Dupe of #22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants