Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(markup): improve first look readability/distinction #77

Conversation

AlejandroSuero
Copy link
Contributor

@scottmckendry I was writing some md file and I notice that there is not much distinction between some treesitter variables.

No changes made

Here are the changes I propose:

After the changes

In my opinion, I think it improves the readability at a first glance since you can distinguish better the parts.

Note

I chose this colours, but it can be change, whatever feels better to the general colorscheme.

@scottmckendry
Copy link
Owner

I like it! Nice work 🙂
My only feedback is to invert the bg and fg values for the checked and unchecked boxes.

E.g.:

["@markup.list.unchecked"] = { fg = t.magenta, bold = true },
["@markup.list.checked"] = { fg = t.green, bold = true },

@AlejandroSuero
Copy link
Contributor Author

@scottmckendry I made these changes, tell me what do you think looks best.

  • With bg = t.bg_solid:
bg = t.bg_solid
  • Without bg:
without bg

@scottmckendry
Copy link
Owner

I think without bg looks best 👍🏻

@AlejandroSuero
Copy link
Contributor Author

@scottmckendry committed the changes 👍🏼

@scottmckendry scottmckendry merged commit 8546564 into scottmckendry:main Jun 17, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants