Waterfaller into presto #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is anyone actively working on making waterfaller.py compatible with filterbank files? I may even be willing to offer to help if that helps speed things along. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Scott,
To get the ball rolling on getting the waterfaller into PRESTO, I put the code into presto and did a little bit of testing to make sure it works. A lot of the credit should go to Patrick since he wrote spectra.py, the updated psrfits.py, and the original waterfaller.py.
There are still more I'd like to do, e.g. add a filterbank.py (from Patrick's pypulsar) that uses spectra.py so that the waterfaller can run on .fil files. But, that will take more work and testing since the current filterbank.py in presto is used in injectpsr.py and I'd like to not break that script.
Let me know if you have any questions!