Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix release v 0.20.1 #326

Merged
merged 5 commits into from
Oct 3, 2023
Merged

bugfix release v 0.20.1 #326

merged 5 commits into from
Oct 3, 2023

Conversation

ocramz
Copy link
Collaborator

@ocramz ocramz commented Oct 3, 2023 •
edited
Loading

closes #325 , closes #323

@ocramz ocramz marked this pull request as ready for review October 3, 2023 12:26
@ocramz ocramz self-assigned this Oct 3, 2023
@ocramz ocramz mentioned this pull request Oct 3, 2023
Closed
@RyanGlScott
Copy link
Contributor

Thanks!

I do think it's worth raising the upper version bounds on base if you don't intend to test pre-8.10 versions of GHC. Otherwise, it's quite easy for build errors to sneak in.

@ocramz
Copy link
Collaborator Author

ocramz commented Oct 3, 2023

OK I've also re-added the 'MonadError' instance which is also missing in 0.20, but in a specialized form since ActionT does not use checked exceptions.

@ocramz
Copy link
Collaborator Author

ocramz commented Oct 3, 2023

@RyanGlScott could you check the instance implementations when you have a minute? I think the overall new design of exceptions is pretty coherent but I'd love your input on this.

RyanGlScott
RyanGlScott approved these changes Oct 3, 2023
View reviewed changes
Copy link
Contributor

@RyanGlScott RyanGlScott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The implementations of these instances look reasonable.

@ocramz ocramz merged commit bb50e65 into scotty-web:master Oct 3, 2023
5 checks passed
@ocramz
Copy link
Collaborator Author

ocramz commented Oct 3, 2023

Thanks @RyanGlScott !

@ocramz ocramz deleted the bugfix-0.20.1-#325 branch October 3, 2023 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RyanGlScott RyanGlScott RyanGlScott approved these changes

Assignees

@ocramz ocramz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bugfix release 0.20.1 ActionT's MonadFail instance removed in scotty-0.20
2 participants
@ocramz @RyanGlScott