Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Locales types generator #2031

Merged
merged 15 commits into from
Aug 19, 2024
Merged

Conversation

Moonded
Copy link
Contributor

@Moonded Moonded commented Aug 15, 2024

Ok, so after fixing my git mistakes, here the PR for generating types based on fluent locale files.

edit: at this point im not sure if i actually fixed my git mistakes

locales/typed/.gitignore Outdated Show resolved Hide resolved
locales/typed/index.ts Outdated Show resolved Hide resolved
locales/typed/package.json Show resolved Hide resolved
locales/typed/pnpm-lock.yaml Show resolved Hide resolved
@emmiegit
Copy link
Member

Thanks for these changes! Left a few comments.

Also, automation thought:

How can we test this in CI? To make sure the types file is valid and up-to-date

@Moonded
Copy link
Contributor Author

Moonded commented Aug 15, 2024

Thanks for these changes! Left a few comments.

Also, automation thought:

How can we test this in CI? To make sure the types file is valid and up-to-date

Not quite sure, but I guess, worst case scenario would be to force generate new one on each build. But they are mainly used in development only anyways and everything would work without them too.

@emmiegit
Copy link
Member

Thanks for these changes! Left a few comments.
Also, automation thought:
How can we test this in CI? To make sure the types file is valid and up-to-date

Not quite sure, but I guess, worst case scenario would be to force generate new one on each build. But they are mainly used in development only anyways and everything would work without them too.

Sure, but I am asking since I would like to be able to automatically catch when these go out of date.

framerail/.gitattributes Outdated Show resolved Hide resolved
framerail/.gitignore Outdated Show resolved Hide resolved
locales/typed/.gitattributes Outdated Show resolved Hide resolved
@emmiegit emmiegit merged commit 731196b into scpwiki:develop Aug 19, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants