Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding swedish language #305

Merged
merged 7 commits into from
May 21, 2017

Conversation

eragnms
Copy link
Contributor

@eragnms eragnms commented Apr 10, 2017

I have added the Swedish language and tests for it.

/M

@codecov-io
Copy link

codecov-io commented Apr 10, 2017

Codecov Report

Merging #305 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #305   +/-   ##
=======================================
  Coverage   78.85%   78.85%           
=======================================
  Files          34       34           
  Lines        4001     4001           
=======================================
  Hits         3155     3155           
  Misses        846      846
Impacted Files Coverage Δ
tests/test_languages.py 99.32% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29ba09b...f563ee2. Read the comment docs.

@@ -1,5 +1,5 @@
# -*- coding: utf-8 -*-
__version__ = '0.6.0'
__version__ = '0.7.0.dev1'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you might want to revert this change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about the procedures for pull requests, but I believe I have reverted as you proposed.
Thanks for the comment!

@@ -10,7 +10,6 @@

from tests import BaseTestCase


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

double blank lines are recommended between imports and class definition. Please revert this change.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated...
Thanks

@waqasshabbir waqasshabbir merged commit f563ee2 into scrapinghub:master May 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants