Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update th.yaml #345

Merged
merged 2 commits into from
Oct 30, 2017
Merged

Update th.yaml #345

merged 2 commits into from
Oct 30, 2017

Conversation

andjelx
Copy link
Contributor

@andjelx andjelx commented Aug 22, 2017

Added ที่ (thi) at the end for days of week

Added ที่ (thi) for days of week
@codecov
Copy link

codecov bot commented Aug 22, 2017

Codecov Report

Merging #345 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #345   +/-   ##
=======================================
  Coverage   97.61%   97.61%           
=======================================
  Files          20       20           
  Lines        1674     1674           
=======================================
  Hits         1634     1634           
  Misses         40       40

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5308434...850e382. Read the comment docs.

@tastepwalle
Copy link

Seems this PR passed..we need this update can it be merged? :)

Awesome library btw

@asadurski
Copy link
Member

Can you please add some tests for those weekdays to make it quicker? (Or suggest date strings and datetime result for those).

@andjelx
Copy link
Contributor Author

andjelx commented Sep 6, 2017

I will add tests

@andjelx
Copy link
Contributor Author

andjelx commented Sep 7, 2017

I have added few tests

@andjelx
Copy link
Contributor Author

andjelx commented Oct 9, 2017

Hello @asadurski do you have any feedback on my PR?
Travis failed only on one job and seems it's an internal issue not related to PR itself.

@asadurski
Copy link
Member

You're right, the problem was with the setup of tests in Travis.
Thank you for contribution. Apologies for long wait time.

@asadurski asadurski merged commit 1c54cea into scrapinghub:master Oct 30, 2017
@tastepwalle
Copy link

@asadurski thanks for merging, much appreciated.

By chance do you know when the PyPI package will be updated? Thanks, P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants