-
Notifications
You must be signed in to change notification settings - Fork 466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix milliseconds parsing #572
Conversation
d10xa
commented
Oct 5, 2019
•
edited
Loading
edited
Codecov Report
@@ Coverage Diff @@
## master #572 +/- ##
=========================================
Coverage ? 95.21%
=========================================
Files ? 302
Lines ? 2507
Branches ? 0
=========================================
Hits ? 2387
Misses ? 120
Partials ? 0
Continue to review full report at Codecov.
|
I think you may be over complicating your implementation. I think it may be better to modify As for tests, you should be able to simply extend the existing |
Co-Authored-By: Adrián Chaves <adrian@chaves.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job @d10xa ! 😄